Skip to content

Conversation

@smilkuri
Copy link
Contributor

@smilkuri smilkuri commented Mar 25, 2025

Issue

Internal 5781

Description

It enables full output logs only for the packages with errors during the Turbo build by changing the configuration from output-logs=hash-only to output-logs=errors-only.

Testing

Locally.
Build output before making the change if there is any error in a workspace:

@aws-sdk/cloudfront-signer:build: ERROR: command finished with error: command (/local/home/smilkuri/aws-sdk-js-v3/packages/cloudfront-signer) /tmp/xfs-45e744bc/yarn run build exited (1)
@aws-sdk/util-user-agent-node:build: cache hit, suppressing logs 250d8ac137df25a0
@aws-sdk/signature-v4-multi-region:build: cache hit, suppressing logs cc2e11db6290d72a
@aws-sdk/cloudfront-signer#build: command (/local/home/smilkuri/aws-sdk-js-v3/packages/cloudfront-signer) /tmp/xfs-45e744bc/yarn run build exited (1)

 Tasks:    52 successful, 53 total
Cached:    52 cached, 53 total
  Time:    12.141s 
Failed:    @aws-sdk/cloudfront-signer#build

 ERROR  run failed: command  exited (1)
Error running turbo: yarn failed with { code: 1, signal: null }
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "yarn failed with { code: 1, signal: null }".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v18.20.2

After making the change if there is an error in a workspace:

@aws-sdk/cloudfront-signer:build: cache miss, executing 64ae2e594474d05a
@aws-sdk/cloudfront-signer:build: 
@aws-sdk/cloudfront-signer:build: [build:es] src/sign.ts(10,3): error TS2322: Type 'number' is not assignable to type 'string'.
@aws-sdk/cloudfront-signer:build: [build:types] src/sign.ts(10,3): error TS2322: Type 'number' is not assignable to type 'string'.
@aws-sdk/cloudfront-signer:build: [build:es] yarn run build:es exited with code 2
@aws-sdk/cloudfront-signer:build: [build:types] yarn run build:types exited with code 2
@aws-sdk/cloudfront-signer:build: [build:cjs] src/sign.ts(10,3): error TS2322: Type 'number' is not assignable to type 'string'.
@aws-sdk/cloudfront-signer:build: [build:cjs] node:internal/process/promises:288
@aws-sdk/cloudfront-signer:build: [build:cjs]             triggerUncaughtException(err, true /* fromPromise */);
@aws-sdk/cloudfront-signer:build: [build:cjs]             ^
@aws-sdk/cloudfront-signer:build: [build:cjs] 
@aws-sdk/cloudfront-signer:build: [build:cjs] [UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "yarn failed with { code: 2, signal: null }".] {
@aws-sdk/cloudfront-signer:build: [build:cjs]   code: 'ERR_UNHANDLED_REJECTION'
@aws-sdk/cloudfront-signer:build: [build:cjs] }
@aws-sdk/cloudfront-signer:build: [build:cjs] 
@aws-sdk/cloudfront-signer:build: [build:cjs] Node.js v18.20.2
@aws-sdk/cloudfront-signer:build: [build:cjs] yarn run build:cjs exited with code 1
@aws-sdk/cloudfront-signer:build: ERROR: command finished with error: command (/local/home/smilkuri/aws-sdk-js-v3/packages/cloudfront-signer) /tmp/xfs-d572b394/yarn run build exited (1)
@aws-sdk/cloudfront-signer#build: command (/local/home/smilkuri/aws-sdk-js-v3/packages/cloudfront-signer) /tmp/xfs-d572b394/yarn run build exited (1)

 Tasks:    52 successful, 53 total
Cached:    52 cached, 53 total
  Time:    12.114s 
Failed:    @aws-sdk/cloudfront-signer#build

 ERROR  run failed: command  exited (1)
Error running turbo: yarn failed with { code: 1, signal: null }
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "yarn failed with { code: 1, signal: null }".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v18.20.2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner March 25, 2025 15:20
@smilkuri smilkuri changed the title chore(turbo):enable full output logs for turbo build chore(turbo):enable full output logging for turbo build Mar 25, 2025
@smilkuri smilkuri changed the title chore(turbo):enable full output logging for turbo build chore(turbo): enable full output logging for turbo build Mar 25, 2025
@smilkuri smilkuri changed the title chore(turbo): enable full output logging for turbo build chore(turbo): enable full output logging only for the error packages in turbo build Mar 25, 2025
@smilkuri smilkuri changed the title chore(turbo): enable full output logging only for the error packages in turbo build chore(turbo): enable full output logging only for the packages with errors in turbo build Mar 25, 2025
@trivikr trivikr changed the title chore(turbo): enable full output logging only for the packages with errors in turbo build chore(ci): enable error output logging for turbo build Mar 25, 2025
@smilkuri smilkuri merged commit 11baa79 into main Mar 25, 2025
3 of 4 checks passed
@smilkuri smilkuri deleted the JS-5781 branch March 25, 2025 20:15
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants